r/ecs_task_definition - add support for fsx win fs #19670

DrFaust92 · 2021-06-04T16:24:59Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19652

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcsTaskDefinition_'
--- PASS: TestAccAWSEcsTaskDefinition_inferenceAccelerator (119.06s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (120.31s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (121.41s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (122.75s)
--- PASS: TestAccAWSEcsTaskDefinition_arrays (122.84s)
--- PASS: TestAccAWSEcsTaskDefinition_constraint (124.74s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (126.04s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (137.08s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (138.65s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (139.52s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (139.52s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (139.83s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (164.55s)
--- PASS: TestAccAWSEcsTaskDefinition_disappears (165.69s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (101.32s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (174.27s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (176.17s)
--- PASS: TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume (92.86s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (95.93s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (99.88s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (230.38s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (251.57s)
--- PASS: TestAccAWSEcsTaskDefinition_withFsxWinFileSystem (3789.91s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSAccessPoint (51.39s)

website/docs/r/ecs_task_definition.html.markdown

This reverts commit 2ff8db8b63107f398dae08ac74fd7aea705b8aee.

ewbankkit

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsTaskDefinition_'                  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsTaskDefinition_ -timeout 180m
=== RUN   TestAccAWSEcsTaskDefinition_basic
=== PAUSE TestAccAWSEcsTaskDefinition_basic
=== RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withScratchVolume
=== RUN   TestAccAWSEcsTaskDefinition_withDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolume
=== RUN   TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== RUN   TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== RUN   TestAccAWSEcsTaskDefinition_withEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolume
=== RUN   TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== RUN   TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== RUN   TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== PAUSE TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== RUN   TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== RUN   TestAccAWSEcsTaskDefinition_withEcsService
=== PAUSE TestAccAWSEcsTaskDefinition_withEcsService
=== RUN   TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== RUN   TestAccAWSEcsTaskDefinition_withNetworkMode
=== PAUSE TestAccAWSEcsTaskDefinition_withNetworkMode
=== RUN   TestAccAWSEcsTaskDefinition_withIPCMode
=== PAUSE TestAccAWSEcsTaskDefinition_withIPCMode
=== RUN   TestAccAWSEcsTaskDefinition_withPidMode
=== PAUSE TestAccAWSEcsTaskDefinition_withPidMode
=== RUN   TestAccAWSEcsTaskDefinition_constraint
=== PAUSE TestAccAWSEcsTaskDefinition_constraint
=== RUN   TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccAWSEcsTaskDefinition_arrays
=== PAUSE TestAccAWSEcsTaskDefinition_arrays
=== RUN   TestAccAWSEcsTaskDefinition_Fargate
=== PAUSE TestAccAWSEcsTaskDefinition_Fargate
=== RUN   TestAccAWSEcsTaskDefinition_ExecutionRole
=== PAUSE TestAccAWSEcsTaskDefinition_ExecutionRole
=== RUN   TestAccAWSEcsTaskDefinition_disappears
=== PAUSE TestAccAWSEcsTaskDefinition_disappears
=== RUN   TestAccAWSEcsTaskDefinition_Tags
=== PAUSE TestAccAWSEcsTaskDefinition_Tags
=== RUN   TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== PAUSE TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== RUN   TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== PAUSE TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== CONT  TestAccAWSEcsTaskDefinition_basic
=== CONT  TestAccAWSEcsTaskDefinition_withIPCMode
=== CONT  TestAccAWSEcsTaskDefinition_ExecutionRole
=== CONT  TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== CONT  TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== CONT  TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== CONT  TestAccAWSEcsTaskDefinition_Fargate
=== CONT  TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== CONT  TestAccAWSEcsTaskDefinition_constraint
=== CONT  TestAccAWSEcsTaskDefinition_arrays
=== CONT  TestAccAWSEcsTaskDefinition_withPidMode
=== CONT  TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== CONT  TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== CONT  TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== CONT  TestAccAWSEcsTaskDefinition_withEcsService
=== CONT  TestAccAWSEcsTaskDefinition_withNetworkMode
=== CONT  TestAccAWSEcsTaskDefinition_withEFSVolume
=== CONT  TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== CONT  TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== CONT  TestAccAWSEcsTaskDefinition_Tags
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (52.87s)
=== CONT  TestAccAWSEcsTaskDefinition_withScratchVolume
--- PASS: TestAccAWSEcsTaskDefinition_arrays (53.27s)
=== CONT  TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
--- PASS: TestAccAWSEcsTaskDefinition_inferenceAccelerator (55.70s)
=== CONT  TestAccAWSEcsTaskDefinition_disappears
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (59.59s)
=== CONT  TestAccAWSEcsTaskDefinition_withDockerVolume
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (60.86s)
--- PASS: TestAccAWSEcsTaskDefinition_constraint (61.12s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (64.15s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (65.06s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (65.73s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (69.45s)
--- PASS: TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume (70.58s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (73.25s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (73.75s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSAccessPoint (75.37s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (76.75s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (82.88s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (83.44s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (36.94s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (37.40s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (31.00s)
--- PASS: TestAccAWSEcsTaskDefinition_disappears (42.62s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (100.23s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (157.31s)
--- PASS: TestAccAWSEcsTaskDefinition_withFsxWinFileSystem (1420.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1424.417s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsTaskDefinition_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsTaskDefinition_ -timeout 180m
=== RUN   TestAccAWSEcsTaskDefinition_basic
=== PAUSE TestAccAWSEcsTaskDefinition_basic
=== RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withScratchVolume
=== RUN   TestAccAWSEcsTaskDefinition_withDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolume
=== RUN   TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== RUN   TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== RUN   TestAccAWSEcsTaskDefinition_withEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolume
=== RUN   TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== RUN   TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== RUN   TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== PAUSE TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== RUN   TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== RUN   TestAccAWSEcsTaskDefinition_withEcsService
=== PAUSE TestAccAWSEcsTaskDefinition_withEcsService
=== RUN   TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== RUN   TestAccAWSEcsTaskDefinition_withNetworkMode
=== PAUSE TestAccAWSEcsTaskDefinition_withNetworkMode
=== RUN   TestAccAWSEcsTaskDefinition_withIPCMode
=== PAUSE TestAccAWSEcsTaskDefinition_withIPCMode
=== RUN   TestAccAWSEcsTaskDefinition_withPidMode
=== PAUSE TestAccAWSEcsTaskDefinition_withPidMode
=== RUN   TestAccAWSEcsTaskDefinition_constraint
=== PAUSE TestAccAWSEcsTaskDefinition_constraint
=== RUN   TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccAWSEcsTaskDefinition_arrays
=== PAUSE TestAccAWSEcsTaskDefinition_arrays
=== RUN   TestAccAWSEcsTaskDefinition_Fargate
=== PAUSE TestAccAWSEcsTaskDefinition_Fargate
=== RUN   TestAccAWSEcsTaskDefinition_ExecutionRole
=== PAUSE TestAccAWSEcsTaskDefinition_ExecutionRole
=== RUN   TestAccAWSEcsTaskDefinition_disappears
=== PAUSE TestAccAWSEcsTaskDefinition_disappears
=== RUN   TestAccAWSEcsTaskDefinition_Tags
=== PAUSE TestAccAWSEcsTaskDefinition_Tags
=== RUN   TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== PAUSE TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== RUN   TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== PAUSE TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== CONT  TestAccAWSEcsTaskDefinition_basic
=== CONT  TestAccAWSEcsTaskDefinition_ExecutionRole
=== CONT  TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== CONT  TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== CONT  TestAccAWSEcsTaskDefinition_Tags
=== CONT  TestAccAWSEcsTaskDefinition_disappears
=== CONT  TestAccAWSEcsTaskDefinition_withPidMode
=== CONT  TestAccAWSEcsTaskDefinition_constraint
=== CONT  TestAccAWSEcsTaskDefinition_Fargate
=== CONT  TestAccAWSEcsTaskDefinition_withIPCMode
=== CONT  TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== CONT  TestAccAWSEcsTaskDefinition_withNetworkMode
=== CONT  TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== CONT  TestAccAWSEcsTaskDefinition_withEcsService
=== CONT  TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== CONT  TestAccAWSEcsTaskDefinition_arrays
=== CONT  TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== CONT  TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== CONT  TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== CONT  TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== CONT  TestAccAWSEcsTaskDefinition_inferenceAccelerator
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/06/07 06:21:14 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: ClientException: Unsupported field 'inferenceAccelerators'.
        
          on terraform_plugin_test.tf line 2, in resource "aws_ecs_task_definition" "test":
           2: resource "aws_ecs_task_definition" "test" {
        
        
--- SKIP: TestAccAWSEcsTaskDefinition_inferenceAccelerator (6.15s)
=== CONT  TestAccAWSEcsTaskDefinition_withEFSVolume
--- PASS: TestAccAWSEcsTaskDefinition_arrays (65.16s)
=== CONT  TestAccAWSEcsTaskDefinition_withDockerVolume
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (66.20s)
=== CONT  TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
--- PASS: TestAccAWSEcsTaskDefinition_constraint (68.34s)
=== CONT  TestAccAWSEcsTaskDefinition_withScratchVolume
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (74.48s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (76.45s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (77.07s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (77.25s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (77.42s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (78.51s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (78.64s)
--- PASS: TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume (81.40s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (82.39s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSAccessPoint (83.54s)
--- PASS: TestAccAWSEcsTaskDefinition_disappears (85.26s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (59.82s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (91.24s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (91.29s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (29.29s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (27.24s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (29.51s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (106.55s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (131.01s)
=== RUN   TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
    resource_aws_ecs_task_definition_test.go:369: Amazon FSx for Windows File Server volumes for ECS tasks are not supported in GovCloud partition
--- SKIP: TestAccAWSEcsTaskDefinition_withFsxWinFileSystem (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1127.866s

ewbankkit · 2021-06-07T10:25:58Z

@DrFaust92 Thanks for the contribution 🎉 👏.
I pushed a minor change to suppress errors from GovCloud testing.

github-actions · 2021-06-11T12:22:46Z

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2021-07-12T02:06:56Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

add fsx win fs support

310518b

ghost added the size/XL Managed by automation to categorize the size of a PR. label Jun 4, 2021

github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 4, 2021

DrFaust92 added 6 commits June 4, 2021 19:27

changelog

092ab05

fmt

d74c7e1

add iam role to test

e2bb2a5

fix arg

fe3d2c4

fmt

d938d77

fmt

1c5d353

DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 4, 2021

DrFaust92 added 4 commits June 4, 2021 21:55

move to ecs from structure

5fe4b73

better break down of structs

275be28

docs

fdce201

tests

79b9c0a

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jun 4, 2021

github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 4, 2021

DrFaust92 marked this pull request as ready for review June 4, 2021 21:26

DrFaust92 requested a review from a team as a code owner June 4, 2021 21:26

ewbankkit reviewed Jun 6, 2021

View reviewed changes

website/docs/r/ecs_task_definition.html.markdown Outdated Show resolved Hide resolved

ewbankkit reviewed Jun 6, 2021

View reviewed changes

website/docs/r/ecs_task_definition.html.markdown Outdated Show resolved Hide resolved

ewbankkit and others added 4 commits June 7, 2021 06:22

Suppress GovCloud acceptance testing errors.

0564773

docs

7677eb7

Revert "docs"

fac53a1

This reverts commit 2ff8db8b63107f398dae08ac74fd7aea705b8aee.

docs

d12fa5c

ewbankkit force-pushed the r/recs_task_fsx branch from 81934ab to d12fa5c Compare June 7, 2021 10:24

ewbankkit approved these changes Jun 7, 2021

View reviewed changes

ewbankkit merged commit 3d2bc2b into hashicorp:main Jun 7, 2021

github-actions bot added this to the v3.45.0 milestone Jun 7, 2021

ewbankkit mentioned this pull request Jun 14, 2021

tests/provider: Unsupported field 'inferenceAccelerators' (ECS Task Definition) #15685

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021

DrFaust92 deleted the r/recs_task_fsx branch February 12, 2022 12:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/ecs_task_definition - add support for fsx win fs #19670

r/ecs_task_definition - add support for fsx win fs #19670

DrFaust92 commented Jun 4, 2021 •

edited

Loading

ewbankkit left a comment

ewbankkit commented Jun 7, 2021

github-actions bot commented Jun 11, 2021

github-actions bot commented Jul 12, 2021

r/ecs_task_definition - add support for fsx win fs #19670

r/ecs_task_definition - add support for fsx win fs #19670

Conversation

DrFaust92 commented Jun 4, 2021 • edited Loading

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Jun 7, 2021

github-actions bot commented Jun 11, 2021

github-actions bot commented Jul 12, 2021

DrFaust92 commented Jun 4, 2021 •

edited

Loading